[coreboot] Patch merged into coreboot/master: bbc880e amdk8/amdfam10: Use CAR_GLOBAL for sysinfo

gerrit at coreboot.org gerrit at coreboot.org
Wed Nov 28 07:45:06 CET 2012

the following patch was just integrated into master:
commit bbc880eee702fc175d4a3c3e87b682c26c38f940
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Tue Nov 20 18:20:56 2012 +0100

    amdk8/amdfam10: Use CAR_GLOBAL for sysinfo
    This gets rid of the somewhat unstructured placement of AMD's
    sysinfo structure in CAR.
    We used to carve out some CAR space using a Kconfig variable,
    and then put sysinfo there manually (by "virtue" of pointer magic).
    Now it's a variable with the CAR_GLOBAL qualifier, and build
    system magic.
    For this, the following steps were done (but must happen together
    since the intermediates won't build):
    - Add new CAR_GLOBAL sysinfo_car
    - point all sysinfo pointers to sysinfo_car instead of GLOBAL_VAR
      - from CAR setup (no need to reserve the space)
      - commented out code (that was commented out for years)
      - only copy sizeof(sysinfo) into RAM after ram init, where
        before it copied the whole GLOBAL_VAR area.
      - from Kconfig
    Change-Id: I3cbcccd883ca6751326c8e32afde2eb0c91229ed
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Reviewed-on: http://review.coreboot.org/1887
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Reviewed-by: Marc Jones <marcj303 at gmail.com>

See http://review.coreboot.org/1887 for details.


More information about the coreboot mailing list