[coreboot] New patch to review for coreboot: d1603db pirq_route_irqs is private

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Wed Nov 28 12:43:57 CET 2012

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1936


commit d1603dbe0615e4d4defea99eeecfd9fcb5e80605
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Mon Oct 8 09:33:38 2012 +0200

    pirq_route_irqs is private
    Change-Id: I120913dac3150a72c2e66c74872ee00074ee0267
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
 src/arch/x86/boot/pirq_routing.c         | 2 +-
 src/arch/x86/include/arch/pirq_routing.h | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/arch/x86/boot/pirq_routing.c b/src/arch/x86/boot/pirq_routing.c
index 55deac1..ca74862 100644
--- a/src/arch/x86/boot/pirq_routing.c
+++ b/src/arch/x86/boot/pirq_routing.c
@@ -145,7 +145,7 @@ static u8 pirq_get_next_free_irq(u8* pirq, u16 bitmap)
 	return irq;
-void pirq_route_irqs(unsigned long addr)
+static void pirq_route_irqs(unsigned long addr)
 	int i, intx, num_entries;
 	unsigned char irq_slot[MAX_INTX_ENTRIES];
diff --git a/src/arch/x86/include/arch/pirq_routing.h b/src/arch/x86/include/arch/pirq_routing.h
index 9488473..241ec3b 100644
--- a/src/arch/x86/include/arch/pirq_routing.h
+++ b/src/arch/x86/include/arch/pirq_routing.h
@@ -67,10 +67,7 @@ unsigned long copy_pirq_routing_table(unsigned long addr, const struct irq_routi
 unsigned long write_pirq_routing_table(unsigned long start);
-void pirq_route_irqs(unsigned long start);
 void pirq_assign_irqs(const unsigned char pirq[CONFIG_MAX_PIRQ_LINKS]);
-#define pirq_route_irqs(start) {}

More information about the coreboot mailing list