[coreboot] Patch set updated for coreboot: c2322b8 Make set_boot_successful depend on PC80_SYSTEM

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri Nov 30 21:09:58 CET 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1954

-gerrit

commit c2322b83fcb7d39f633728ad8612d2e388fa6389
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Fri Nov 30 12:03:46 2012 -0800

    Make set_boot_successful depend on PC80_SYSTEM
    
    Set_boot_successful depends on CMOS parts that non-PC80
    platforms do not have. For now, make the current path
    depend on CONFIG_PC80_SYSTEM, and make the alternative
    empty.
    
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
    Change-Id: I68cf63367c8054d09a7a22303e7c04fb35ad0153
---
 src/include/fallback.h  |  1 -
 src/lib/fallback_boot.c | 11 +++++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/include/fallback.h b/src/include/fallback.h
index ffcbafb..7f3c823 100644
--- a/src/include/fallback.h
+++ b/src/include/fallback.h
@@ -3,7 +3,6 @@
 
 #if !defined(__ASSEMBLER__) && !defined(__PRE_RAM__)
 
-void set_boot_successful(void);
 void boot_successful(void);
 
 #endif /* __ASSEMBLER__ */
diff --git a/src/lib/fallback_boot.c b/src/lib/fallback_boot.c
index b5ec6c3..ce1ba85 100644
--- a/src/lib/fallback_boot.c
+++ b/src/lib/fallback_boot.c
@@ -1,11 +1,12 @@
 #include <console/console.h>
 #include <fallback.h>
 #include <watchdog.h>
-#include <pc80/mc146818rtc.h>
 #include <arch/io.h>
 
+#if CONFIG_PC80_SYSTEM
+#include <pc80/mc146818rtc.h>
 
-void set_boot_successful(void)
+static void set_boot_successful(void)
 {
 	/* Remember I succesfully booted by setting
 	 * the initial boot direction
@@ -25,6 +26,12 @@ void set_boot_successful(void)
 		byte &= 0x0f;
 	outb(byte, RTC_PORT(1));
 }
+#else
+static void set_boot_successful(void)
+{
+	/* To be implemented */
+}
+#endif
 
 void boot_successful(void)
 {




More information about the coreboot mailing list