[coreboot] New patch to review for coreboot: 33fc183 Revert order in VGA device choice

Aladyshev Konstantin (kostr@list.ru) gerrit at coreboot.org
Sat Oct 6 11:50:26 CEST 2012


Aladyshev Konstantin (kostr at list.ru) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1561

-gerrit

commit 33fc183e24db943bff249bca42cb8946e84ffd4a
Author: Kostr <aladyshev at nicevt.ru>
Date:   Sat Oct 6 13:27:58 2012 +0400

    Revert order in VGA device choice
    
    Before change "Simplify VGA card discovery"
    (http://review.coreboot.org/#/c/1255/)
    coreboot was setting up VGA for the last found VGA device.
    After this change it setting up VGA for the first found.
    This change broke compatibility to my Supermicro H8QGI board.
    Revert order back to old to save compatibility for this board
    (and maybe any other boards)
    
    Change-Id: Id5f2be60f95298059651c26133806e2694ff60aa
    Signed-off-by: Kostr <aladyshev at nicevt.ru>
---
 src/devices/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/devices/device.c b/src/devices/device.c
index 6b1902d..f021c9b 100644
--- a/src/devices/device.c
+++ b/src/devices/device.c
@@ -732,7 +732,7 @@ static void set_vga_bridge_bits(void)
 
 		if (dev->on_mainboard) {
 			vga_onboard = dev;
-		} else if (!vga) {
+		} else {
 			vga = dev;
 		}
 




More information about the coreboot mailing list