[coreboot] New patch to review for coreboot: f66a086 Take care of NULL chip_ops->name

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sun Oct 7 15:10:14 CEST 2012


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1565

-gerrit

commit f66a0861572e198bffa8a31af56871044ea81781
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sun Oct 7 14:57:15 2012 +0200

    Take care of NULL chip_ops->name
    
    Change-Id: I62b1c497d23ec2241efb963e7834728085824016
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/arch/x86/boot/smbios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/arch/x86/boot/smbios.c b/src/arch/x86/boot/smbios.c
index 8877f60..a171707 100644
--- a/src/arch/x86/boot/smbios.c
+++ b/src/arch/x86/boot/smbios.c
@@ -278,7 +278,8 @@ static int smbios_walk_device_tree(device_t tree, int *handle, unsigned long *cu
 	int len = 0;
 
 	for(dev = tree; dev; dev = dev->next) {
-		printk(BIOS_INFO, "%s (%s)\n", dev_path(dev), dev->chip_ops ? dev->chip_ops->name : "");
+		printk(BIOS_INFO, "%s (%s)\n", dev_path(dev),
+			(dev->chip_ops && dev->chip_ops->name) ? dev->chip_ops->name : "");
 
 		if (dev->ops && dev->ops->get_smbios_data)
 			len += dev->ops->get_smbios_data(dev, handle, current);




More information about the coreboot mailing list