[coreboot] New patch to review for coreboot: 3646090 northbridge/sch: read the size of main memory from the proper register

Sebastian Andrzej Siewior (sebastian@breakpoint.cc) gerrit at coreboot.org
Fri Oct 26 19:16:34 CEST 2012


Sebastian Andrzej Siewior (sebastian at breakpoint.cc) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1629

-gerrit

commit 364609066b3ad1be8c5827405d6d3813c72a65a6
Author: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
Date:   Fri Oct 26 19:01:45 2012 +0200

    northbridge/sch: read the size of main memory from the proper register
    
    I don't know if the size main memory supposed to be in PCI(0,0) reg 0x9c
    but it is not written there. The size of memory is written in
    src/northbridge/intel/sch/raminit.c to SCH port(2, 8, 4) (look for
    "Setting up TOM").
    
    Change-Id: Iea04a5185bda56f61d1c382533d5a0dac429ebbd
    Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
---
 src/northbridge/intel/sch/northbridge.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/northbridge/intel/sch/northbridge.c b/src/northbridge/intel/sch/northbridge.c
index 4ca1248..4c41d68 100644
--- a/src/northbridge/intel/sch/northbridge.c
+++ b/src/northbridge/intel/sch/northbridge.c
@@ -111,10 +111,10 @@ static void pci_domain_set_resources(device_t dev)
 	printk(BIOS_SPEW, "Base of stolen memory: 0x%08x\n",
 	       pci_read_config32(dev_find_slot(0, PCI_DEVFN(2, 0)), 0x5c));
 
-	tolud = pci_read_config8(dev_find_slot(0, PCI_DEVFN(0, 0)), 0x9c);
-	printk(BIOS_SPEW, "Top of Low Used DRAM: 0x%08llx\n", tolud << 24);
+	tolud = sch_port_access_read(2, 8, 4);
+	printk(BIOS_SPEW, "Top of Low Used DRAM: 0x%08llx\n", tolud);
 
-	tomk = tolud << 14;
+	tomk = tolud / 1024;
 	tomk_stolen = tomk;
 
 	/* Note: subtract IGD device and TSEG. */




More information about the coreboot mailing list