[coreboot] Patch merged into coreboot/master: 1485980 Fix ExecuteFinalHltInstruction function in f15h family code

gerrit at coreboot.org gerrit at coreboot.org
Tue Oct 30 05:49:14 CET 2012


the following patch was just integrated into master:
commit 148598054c34c601273b69a67d7db2d2b88da48c
Author: Kostr <aladyshev at nicevt.ru>
Date:   Mon Oct 8 22:04:53 2012 +0400

    Fix ExecuteFinalHltInstruction function in f15h family code
    
    Current ExecuteFinalHltInstruction function doesn't work well.
    (at least in configuration
    Supermicro board with Orochi AMD Opteron processors (model OS6234WKTCGGU))
    
    System reboots when trying to halt core 2,4,6,8 or 10
    (OS6234WKTCGGU is 12 core processor)
    Based on this information, i think that code doesn't really work with
    f15 compute unit (CU) system.
    
    Replacing ExecuteFinalHltInstruction function with
    analogous function from f15tn family code fix this problem.
    Both functions written from the same cahalt.asm file, but f15tn version
    seems more completed
    
    Change-Id: I3942abcdf21f1b86a44c01cc477714e44a40b9cf
    Signed-off-by: Kostr <aladyshev at nicevt.ru>

Build-Tested: build bot (Jenkins) at Mon Oct  8 21:20:32 2012, giving +1
Reviewed-By: Marc Jones <marcj303 at gmail.com> at Tue Oct 30 05:49:13 2012, giving +2
See http://review.coreboot.org/1569 for details.

-gerrit




More information about the coreboot mailing list