[coreboot] New patch to review for coreboot: afb58bf buildsystem: ensure directory exists before use

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Fri Sep 21 18:14:03 CEST 2012

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1532


commit afb58bfd0df28c0d59126129322be953d1db6060
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Fri Sep 21 18:11:59 2012 +0200

    buildsystem: ensure directory exists before use
    In some cases we request mktemp to create a temporary file in
    $(obj)/mainboard/... before it exists.
    Let's make sure the directory exists
    Change-Id: I51f0065c30b1f25eb501a6fd5edefb3f4c15d0ab
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
 Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index bcf0e6e..a214a86 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -126,7 +126,7 @@ cbfs-files-handler= \
 			$(eval tmp-cbfs-file:= $($(2)-file))) \
 		$(if $(tmp-cbfs-method), \
 			$(eval tmp-old-cbfs-file:=$(tmp-cbfs-file)) \
-			$(eval tmp-cbfs-file:=$(shell mktemp $(obj)/mainboard/$(MAINBOARDDIR)/cbfs-file.XXXXXX).out) \
+			$(eval tmp-cbfs-file:=$(shell mkdir -p $(obj)/mainboard/$(MAINBOARDDIR); mktemp $(obj)/mainboard/$(MAINBOARDDIR)/cbfs-file.XXXXXX).out) \
 			$(call cbfs-files-processor-$(tmp-cbfs-method),$(tmp-old-cbfs-file),$(tmp-cbfs-file))) \
 		$(eval cbfs-files += $(tmp-cbfs-file)|$(2)|$($(2)-type)|$($(2)-compression)|$($(2)-position)) \
 		$(eval $(2)-name:=) \

More information about the coreboot mailing list