[coreboot] New patch to review for coreboot: 9d041ec exynos5250: hard-code array index for memory timings

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Fri Feb 1 02:29:22 CET 2013

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2256


commit 9d041ece89e064f5f4c5d510042a0b0348596c6c
Author: David Hendricks <dhendrix at chromium.org>
Date:   Thu Jan 31 17:25:16 2013 -0800

    exynos5250: hard-code array index for memory timings
    Discovering memory timings is a bit complicated due to the need
    to obtain and decode board config. To make things worse, the imported
    code makes a mess of dependencies. Hard-code the memory timings
    for now to get us further along (the instability won't really matter
    until we're loading depthcharge anyway).
    Change-Id: I1f341ad597db0c31ed4ae6bc703fc22b6596a803
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
 src/cpu/samsung/exynos5250/clock_init.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/cpu/samsung/exynos5250/clock_init.c b/src/cpu/samsung/exynos5250/clock_init.c
index 565abe1..421d880 100644
--- a/src/cpu/samsung/exynos5250/clock_init.c
+++ b/src/cpu/samsung/exynos5250/clock_init.c
@@ -725,6 +725,9 @@ struct arm_clk_ratios *get_arm_ratios(void)
 struct mem_timings *clock_get_mem_timings(void)
+	/* FIXME: hard-coded for now */
+	return &mem_timings[0];
+#if 0
 	struct mem_timings *mem;
 	enum ddr_mode mem_type;
 	enum mem_manuf mem_manuf;
@@ -742,6 +745,7 @@ struct mem_timings *clock_get_mem_timings(void)
 	return NULL;
 void system_clock_init(void)

More information about the coreboot mailing list