[coreboot] New patch to review for coreboot: 2641490 exynos5250: remove CPU check from samsung_get_base_* macro
David Hendricks (dhendrix@chromium.org)
gerrit at coreboot.org
Sun Feb 3 05:22:38 CET 2013
David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2264
-gerrit
commit 2641490cfd9edab12ae35b2c3e36c11b31828949
Author: David Hendricks <dhendrix at chromium.org>
Date: Sat Feb 2 20:19:58 2013 -0800
exynos5250: remove CPU check from samsung_get_base_* macro
The cpu_is_exynos5() macro seems broken at the moment, so skip it.
The macro is superfluous and will probably be replaced eventually,
but at least this will un-break usage sites.
Change-Id: Ibd360cbfa18047ad8a3488d4f24c3fc4d7415eba
Signed-off-by: David Hendricks <dhendrix at chromium.org>
---
src/cpu/samsung/exynos5250/cpu.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/cpu/samsung/exynos5250/cpu.h b/src/cpu/samsung/exynos5250/cpu.h
index f399a42..b859823 100644
--- a/src/cpu/samsung/exynos5250/cpu.h
+++ b/src/cpu/samsung/exynos5250/cpu.h
@@ -81,11 +81,19 @@
#ifndef __ASSEMBLER__
+/* FIXME(dhendrix): cpu_is_exynos5() seems broken atm... */
+#if 0
#define SAMSUNG_BASE(device, base) \
static inline unsigned int samsung_get_base_##device(void) \
{ \
return cpu_is_exynos5() ? EXYNOS5_##base : 0; \
}
+#endif
+#define SAMSUNG_BASE(device, base) \
+static inline unsigned int samsung_get_base_##device(void) \
+{ \
+ return EXYNOS5_##base; \
+}
SAMSUNG_BASE(adc, ADC_BASE)
SAMSUNG_BASE(clock, CLOCK_BASE)
More information about the coreboot
mailing list