[coreboot] Patch merged into coreboot/master: 9efc42e AMD Fam14 - Fix warnings

gerrit at coreboot.org gerrit at coreboot.org
Wed Feb 6 19:47:29 CET 2013


the following patch was just integrated into master:
commit 9efc42e85b4db0735145ddb561d62627f2c11003
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Tue Feb 5 21:06:21 2013 -0700

    AMD Fam14 - Fix warnings
    
    Added casts and a couple of #ifdefs to fix the warnings in the
    vendorcode/amd/agesa/f14 codebase.  This will allow us to re-enable
    'all warnings being treated as errors' in boards such as Persimmon
    that are using this code.  That change will follow.
    
    These are the warnings that are fixed by this patch:
    
    src/vendorcode/amd/agesa/f14/Legacy/Proc/hobTransfer.c: In function 'CopyHeapToTempRamAtPost':
    src/vendorcode/amd/agesa/f14/Legacy/Proc/hobTransfer.c:219:28: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    src/vendorcode/amd/agesa/f14/Legacy/Proc/hobTransfer.c: In function 'CopyHeapToMainRamAtPost':
    src/vendorcode/amd/agesa/f14/Legacy/Proc/hobTransfer.c:372:30: warning: comparison between pointer and integer [enabled by default]
    src/vendorcode/amd/agesa/f14/Legacy/Proc/hobTransfer.c:381:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    
    src/vendorcode/amd/agesa/f14/Proc/CPU/cpuApicUtilities.c: In function 'ApUtilSetupIdtForHlt':
    src/vendorcode/amd/agesa/f14/Proc/CPU/cpuApicUtilities.c:863:19: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    src/vendorcode/amd/agesa/f14/Proc/CPU/cpuApicUtilities.c:872:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    
    src/vendorcode/amd/agesa/f14/Proc/CPU/cpuMicrocodePatch.c: In function 'LoadMicrocode':
    src/vendorcode/amd/agesa/f14/Proc/CPU/cpuMicrocodePatch.c:211:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c: In function 'HeapManagerInit':
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c:167:52: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c:183:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c: In function 'HeapGetBaseAddress':
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c:669:17: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c:676:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c:683:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c:684:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c:687:23: warning: assignment makes integer from pointer without a cast [enabled by default]
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c:691:21: warning: assignment makes integer from pointer without a cast [enabled by default]
    src/vendorcode/amd/agesa/f14/Proc/CPU/heapManager.c:696:3: warning: return makes pointer from integer without a cast [enabled by default]
    
    In file included from src/mainboard/amd/persimmon/agesawrapper.h:30:0,
                     from src/northbridge/amd/agesa/family14/northbridge.c:36:
    src/vendorcode/amd/agesa/f14/AGESA.h:1132:0: warning: "TOP_MEM" redefined [enabled by default]
    In file included from src/northbridge/amd/agesa/family14/northbridge.c:34:0:
    src/include/cpu/amd/mtrr.h:31:0: note: this is the location of the previous definition
    In file included from src/mainboard/amd/persimmon/agesawrapper.h:30:0,
                     from src/northbridge/amd/agesa/family14/northbridge.c:36:
    src/vendorcode/amd/agesa/f14/AGESA.h:1133:0: warning: "TOP_MEM2" redefined [enabled by default]
    In file included from src/northbridge/amd/agesa/family14/northbridge.c:34:0:
    src/include/cpu/amd/mtrr.h:34:0: note: this is the location of the previous definition
    
    Verified on persimmon.
    
    Change-Id: I1671b191c72dfc1d63ada41126ae3418bc8f86ae
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
    Reviewed-on: http://review.coreboot.org/2293
    Tested-by: build bot (Jenkins)
    Reviewed-by: Dave Frodin <dave.frodin at se-eng.com>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Steven Sherk <steven.sherk at se-eng.com>

Build-Tested: build bot (Jenkins) at Wed Feb  6 17:03:19 2013, giving +1
See http://review.coreboot.org/2293 for details.

-gerrit



More information about the coreboot mailing list