[coreboot] New patch to review for coreboot: 72e806b armv7/snow: Remove power_init from bootblock.

Hung-Te Lin (hungte@chromium.org) gerrit at coreboot.org
Thu Feb 7 14:58:02 CET 2013


Hung-Te Lin (hungte at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2317

-gerrit

commit 72e806bb26ee8be37feec1bc7ef06549b52f4260
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Thu Feb 7 21:25:15 2013 +0800

    armv7/snow: Remove power_init from bootblock.
    
    The power_init is not required on Exynos 5250 (snow) in bootblock stage. To get
    a cleaner and faster bootblock, we can remove it.
    
    Note, power_init internally calls max77686 and s3c24x0_i2c, so both files are
    also removed.
    
    Verified to boot on armv7/snow.
    
    Change-Id: I5b15dfe5ac7bf4650565fea0afefc94a228ece29
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
---
 src/cpu/samsung/exynos5250/Makefile.inc | 1 -
 src/cpu/samsung/s5p-common/Makefile.inc | 1 -
 src/drivers/maxim/max77686/Makefile.inc | 1 -
 src/mainboard/google/snow/bootblock.c   | 2 --
 4 files changed, 5 deletions(-)

diff --git a/src/cpu/samsung/exynos5250/Makefile.inc b/src/cpu/samsung/exynos5250/Makefile.inc
index e2033ff..1c6d716 100644
--- a/src/cpu/samsung/exynos5250/Makefile.inc
+++ b/src/cpu/samsung/exynos5250/Makefile.inc
@@ -9,7 +9,6 @@
 bootblock-y += clock_init.c
 bootblock-y += clock.c
 bootblock-y += pinmux.c
-bootblock-y += power.c
 bootblock-y += soc.c
 bootblock-y += uart.c
 
diff --git a/src/cpu/samsung/s5p-common/Makefile.inc b/src/cpu/samsung/s5p-common/Makefile.inc
index 621576d..0f4200c 100644
--- a/src/cpu/samsung/s5p-common/Makefile.inc
+++ b/src/cpu/samsung/s5p-common/Makefile.inc
@@ -1,5 +1,4 @@
 bootblock-y += pwm.c
-bootblock-y += s3c24x0_i2c.c
 bootblock-y += s5p_gpio.c
 bootblock-y += timer.c
 
diff --git a/src/drivers/maxim/max77686/Makefile.inc b/src/drivers/maxim/max77686/Makefile.inc
index 097b291..a5d7b90 100644
--- a/src/drivers/maxim/max77686/Makefile.inc
+++ b/src/drivers/maxim/max77686/Makefile.inc
@@ -17,6 +17,5 @@
 ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 ##
 
-bootblock-$(CONFIG_DRIVER_MAXIM_MAX77686) += max77686.c
 romstage-$(CONFIG_DRIVER_MAXIM_MAX77686) += max77686.c
 ramstage-$(CONFIG_DRIVER_MAXIM_MAX77686) += max77686.c
diff --git a/src/mainboard/google/snow/bootblock.c b/src/mainboard/google/snow/bootblock.c
index 8390ae8..bcfe440 100644
--- a/src/mainboard/google/snow/bootblock.c
+++ b/src/mainboard/google/snow/bootblock.c
@@ -27,7 +27,6 @@
 #include <cpu/samsung/exynos5250/dmc.h>
 #include <cpu/samsung/exynos5250/periph.h>
 #include <cpu/samsung/exynos5250/clock_init.h>
-#include <src/cpu/samsung/exynos5250/power.h>
 
 #endif
 
@@ -37,7 +36,6 @@ void bootblock_mainboard_init(void)
 	struct mem_timings *mem;
 	struct arm_clk_ratios *arm_ratios;
 
-	power_init();
 	mem = get_mem_timings();
 	arm_ratios = get_arm_clk_ratios();
 	system_clock_init(mem, arm_ratios);



More information about the coreboot mailing list