[coreboot] New patch to review for coreboot: 335101f armv7/snow: add BL1_SIZE_KB and get rid of magic constants
David Hendricks (dhendrix@chromium.org)
gerrit at coreboot.org
Sat Feb 9 04:14:33 CET 2013
David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2332
-gerrit
commit 335101f9e6b9252c1ea66065fdcc58547643a956
Author: David Hendricks <dhendrix at chromium.org>
Date: Fri Feb 8 19:10:33 2013 -0800
armv7/snow: add BL1_SIZE_KB and get rid of magic constants
This adds a BL1_SIZE_KB config variable so that we can get rid of
some magic constants.
Change-Id: I9dbcfb407d3f8e367be5d943e95b032ce88b0ad0
Signed-off-by: David Hendricks <dhendrix at chromium.org>
---
src/arch/armv7/bootblock.inc | 2 +-
src/arch/armv7/bootblock.lds | 2 +-
src/cpu/samsung/exynos5250/Kconfig | 4 ++++
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/arch/armv7/bootblock.inc b/src/arch/armv7/bootblock.inc
index 1eb8e11..82d801e 100644
--- a/src/arch/armv7/bootblock.inc
+++ b/src/arch/armv7/bootblock.inc
@@ -36,7 +36,7 @@ _bl1:
* on ARM, which is 8KB in size and it is prepended to the
* reset vector
*/
- .skip 8192
+ .skip CONFIG_BL1_SIZE_KB
.globl _start
_start: b reset
diff --git a/src/arch/armv7/bootblock.lds b/src/arch/armv7/bootblock.lds
index 90e37a0..fc58601 100644
--- a/src/arch/armv7/bootblock.lds
+++ b/src/arch/armv7/bootblock.lds
@@ -25,7 +25,7 @@ OUTPUT_ARCH(arm)
TARGET(binary)
SECTIONS
{
- ROMLOC = 0x2023400 - 8192;
+ ROMLOC = CONFIG_BOOTBLOCK_BASE - CONFIG_BL1_SIZE_KB;
/* This section might be better named .setup */
.rom ROMLOC : {
diff --git a/src/cpu/samsung/exynos5250/Kconfig b/src/cpu/samsung/exynos5250/Kconfig
index 0b07b90..3e61087 100644
--- a/src/cpu/samsung/exynos5250/Kconfig
+++ b/src/cpu/samsung/exynos5250/Kconfig
@@ -14,6 +14,10 @@ config SATA_AHCI
bool
default n
+config BL1_SIZE_KB
+ int
+ default 8192
+
# Example SRAM/iRAM map for Exynos5250 platform:
#
# 0x0202_0000: vendor-provided BL1
More information about the coreboot
mailing list