[coreboot] Patch merged into coreboot/master: 96e3035 AMD SB900: fix warnings

gerrit at coreboot.org gerrit at coreboot.org
Mon Feb 11 08:25:45 CET 2013


the following patch was just integrated into master:
commit 96e3035a1f9f6ade63d31c4f5e6f806df609f5c1
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Sun Feb 10 14:26:20 2013 -0700

    AMD SB900: fix warnings
    
    Add a prototype to a .h file
    Remove an unused file (GppHp.c) from the build by deleting it from the
      makefile. I left the file since this is vendorcode. This is the code
      for PCIe hotplug.
    Inside GppHp.c, make functions not called from outside static.
      This obviously isn't important since the file isn't used, but for
      the sake of the cleanup I thought I'd go ahead with it...
    
    This was tested with the torpedo build.
    
    This fixes these warnings:
    
    src/vendorcode/amd/cimx/sb900/Dispatcher.c: In function 'LocateImage':
    src/vendorcode/amd/cimx/sb900/Dispatcher.c:193:38: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    
    src/vendorcode/amd/cimx/sb900/Usb.c:740:1: warning: no previous prototype for 'XhciA12Fix' [-Wmissing-prototypes]
    
    src/vendorcode/amd/cimx/sb900/GppHp.c:65:1: warning: no previous prototype for 'sbGppHotPlugSmiProcess' [-Wmissing-prototypes]
    src/vendorcode/amd/cimx/sb900/GppHp.c: In function 'sbGppHotPlugSmiProcess':
    src/vendorcode/amd/cimx/sb900/GppHp.c:76:5: warning: implicit declaration of function 'SbStall' [-Wimplicit-function-declaration]
    src/vendorcode/amd/cimx/sb900/GppHp.c: At top level:
    src/vendorcode/amd/cimx/sb900/GppHp.c:101:1: warning: no previous prototype for 'sbGppHotUnplugSmiProcess' [-Wmissing-prototypes]
    src/vendorcode/amd/cimx/sb900/GppHp.c:134:1: warning: no previous prototype for 'sbGppHotplugSmiCallback' [-Wmissing-prototypes]
    src/vendorcode/amd/cimx/sb900/GppHp.c: In function 'sbGppHotplugSmiCallback':
    src/vendorcode/amd/cimx/sb900/GppHp.c:158:5: warning: implicit declaration of function 'outPort80' [-Wimplicit-function-declaration]
    
    Change-Id: I5a1a20eeb81e1f4d59e3e3192f081e11d8506f56
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
    Reviewed-on: http://review.coreboot.org/2349
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>

Reviewed-By: Patrick Georgi <patrick at georgi-clan.de> at Mon Feb 11 08:25:44 2013, giving +2
See http://review.coreboot.org/2349 for details.

-gerrit



More information about the coreboot mailing list