[coreboot] Merges too fast not giving a chance for proper review

Paul Menzel paulepanter at users.sourceforge.net
Tue Feb 12 12:15:46 CET 2013


Dear Duncan,


Am Montag, den 11.02.2013, 15:15 -0800 schrieb Duncan Laurie:
> On Mon, Feb 11, 2013 at 2:08 PM, Paul Menzel wrote:
> 
> > Am Montag, den 11.02.2013, 22:51 +0100 schrieb Peter Stuge:
> > > Stefan Reinauer wrote:
> > > > Date: Mon, 11 Feb 2013 21:09:57 +0100
> > > >
> > > > Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new
> > patch set
> >
> > First congrats to the new port!
> >
> > > gerrit at coreboot.org wrote:
> > > > Date: Mon, 11 Feb 2013 22:02:33 +0100
> > > >
> > > > the following patch was just integrated into master:
> > > > commit d7bd4eb003f5b6a13943418ae0ac53248a2e34d2
> > >
> > > I understand that you're eager to get things in, but maybe you could
> > > let a new board sit for more than an hour?
> >
> > Reading the latest coreboot messages coming back to the PC I thought the
> > same.
> >
> > > I just finished review and had one or two questions. I did find a few
> > > things perhaps worth discussing..
> >
> > I did not even have time to look at it yet.
> 
> Sorry, I should have added +1 instead of +2.

I think +2 is ok. Commits/Changes still need to be cherry-picked
manually by pressing the Merge(?) button, which Stefan did.

[…]


Thanks,

Paul


PS: Could you just sent plain text message (no HTML) please. I sometimes
still use a traffic size(?) limited UMTS connection. So every KB
counts. ;-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20130212/1f19616b/attachment.sig>


More information about the coreboot mailing list