[coreboot] New patch to review for coreboot: 25b5ce2 armv7: don't write a forward entry in coreboot tables

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Thu Feb 14 05:02:52 CET 2013

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2385


commit 25b5ce286fa0c8603e1d5401f248f7434304f76f
Author: David Hendricks <dhendrix at chromium.org>
Date:   Wed Feb 13 20:00:49 2013 -0800

    armv7: don't write a forward entry in coreboot tables
    We don't seem to need it, and it currently confuses the payload.
    (credit to Gabe Black for this, I'm just uploading it)
    Change-Id: I4e3a60eceb9b24e3bc8e50db431c1a731d1cdbae
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
 src/arch/armv7/boot/coreboot_table.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/src/arch/armv7/boot/coreboot_table.c b/src/arch/armv7/boot/coreboot_table.c
index ed105a4..64f6a66 100644
--- a/src/arch/armv7/boot/coreboot_table.c
+++ b/src/arch/armv7/boot/coreboot_table.c
@@ -329,20 +329,6 @@ static void lb_strings(struct lb_header *header)
-static struct lb_forward *lb_forward(struct lb_header *header, struct lb_header *next_header)
-	struct lb_record *rec;
-	struct lb_forward *forward;
-	rec = lb_new_record(header);
-	forward = (struct lb_forward *)rec;
-	forward->tag = LB_TAG_FORWARD;
-	forward->size = sizeof(*forward);
-	forward->forward = (uint64_t)(unsigned long)next_header;
-	return forward;
 /* FIXME(dhendrix): used to be static void lb_memory_range(), but compiler
    started complaining since it shares a name with a non-static struct. ugh. */
 static void new_lb_memory_range(struct lb_memory *mem,
@@ -612,10 +598,6 @@ unsigned long write_coreboot_table(
 			   table_start, table_end);
 	head = lb_table_init(table_start);
-	printk(BIOS_DEBUG, "Writing table forward entry at 0x%08lx\n",
-			table_end);
-	lb_forward(head, (struct lb_header*)table_end);
 	table_end = (unsigned long) head + head->table_bytes;
 	/* FIXME(dhendrix): do we need this? */

More information about the coreboot mailing list