[coreboot] New patch to review for coreboot: 9893316 snow: remove superfluous printk's from romstage main

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Thu Feb 14 05:32:41 CET 2013

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2386


commit 9893316859618bc3c42c457e58e3e566b455d205
Author: David Hendricks <dhendrix at chromium.org>
Date:   Wed Feb 13 20:29:27 2013 -0800

    snow: remove superfluous printk's from romstage main
    These were left over from earlier debugging and are no longer
    needed. They don't indicate any status or useful info (other
    than which line of code has been executed). Error messages are
    available in case something needs attention.
    Change-Id: Ie09fac29c42908cb8924169e56d8927fb76f02da
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
 src/mainboard/google/snow/romstage.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/mainboard/google/snow/romstage.c b/src/mainboard/google/snow/romstage.c
index f6f858c..9891011 100644
--- a/src/mainboard/google/snow/romstage.c
+++ b/src/mainboard/google/snow/romstage.c
@@ -64,7 +64,6 @@ void main(void)
 	system_clock_init(mem, arm_ratios);
-	printk(BIOS_INFO, "hello from romstage\n");
 	if (!mem) {
 		printk(BIOS_CRIT, "Unable to auto-detect memory timings\n");
@@ -83,8 +82,6 @@ void main(void)
-	printk(BIOS_INFO, "ddr3_init done\n");
 	entry = cbfs_load_stage(CBFS_DEFAULT_MEDIA, "fallback/coreboot_ram");

More information about the coreboot mailing list