[coreboot] New patch to review for coreboot: 3b8c8db cbfstool: Add `-Werror` to make all warnings into errors

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Feb 18 12:00:48 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2441

-gerrit

commit 3b8c8db3ef61a3c086fe2abf322000d14b737871
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Feb 18 11:56:13 2013 +0100

    cbfstool: Add `-Werror` to make all warnings into errors
    
    Ensure that no changes with warnings are committed. Although using
    `-Werror` is debatable [1][2].
    
    [1] http://blog.flameeyes.eu/2009/02/future-proof-your-code-dont-use-werror
    [2] http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
    
    Change-Id: I402f2d82dd4087d8a575b0a85305a02ef04bb537
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 util/cbfstool/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile
index 3ace744..a14a76f 100644
--- a/util/cbfstool/Makefile
+++ b/util/cbfstool/Makefile
@@ -2,7 +2,7 @@ obj ?= $(shell pwd)
 
 HOSTCXX  ?= g++
 HOSTCC   ?= gcc
-CFLAGS   ?= -g -Wall
+CFLAGS   ?= -g -Wall -Werror
 CFLAGS   += -D_7ZIP_ST
 
 BINARY:=$(obj)/cbfstool



More information about the coreboot mailing list