[coreboot] New patch to review for coreboot: 5f607b1 Kconfig: string option doesn't work properly inside choice section

Jens Rottmann (JRottmann@LiPPERTembedded.de) gerrit at coreboot.org
Mon Feb 18 17:29:22 CET 2013


Jens Rottmann (JRottmann at LiPPERTembedded.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2443

-gerrit

commit 5f607b11ba3846a747a39284d82a99d2a3089d39
Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
Date:   Mon Feb 18 17:26:01 2013 +0100

    Kconfig: string option doesn't work properly inside choice section
    
    At least not in menuconfig. Move it after the endchoice.
    
    Change-Id: I87d2f70e7c1fbe539cd78cb602a39335b2886d8d
    Signed-off-by: Jens Rottmann <JRottmann at LiPPERTembedded.de>
---
 src/cpu/Kconfig | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/cpu/Kconfig b/src/cpu/Kconfig
index caf4ebc..bb27da0 100644
--- a/src/cpu/Kconfig
+++ b/src/cpu/Kconfig
@@ -106,13 +106,6 @@ config CPU_MICROCODE_CBFS_EXTERNAL
 
 	  If unsure, select "Generate from tree"
 
-config CPU_MICROCODE_FILE
-	  string "Path and filename of CPU microcode"
-	  depends on CPU_MICROCODE_CBFS_EXTERNAL
-	  default "cpu_microcode.bin"
-	  help
-	    The path and filename of the file containing the CPU microcode.
-
 config CPU_MICROCODE_CBFS_NONE
 	bool "Do not include microcode updates"
 	help
@@ -156,3 +149,10 @@ config CPU_MICROCODE_CBFS_NONE
 	  selecting this option.
 
 endchoice
+
+config CPU_MICROCODE_FILE
+	  string "Path and filename of CPU microcode"
+	  depends on CPU_MICROCODE_CBFS_EXTERNAL
+	  default "cpu_microcode.bin"
+	  help
+	    The path and filename of the file containing the CPU microcode.



More information about the coreboot mailing list