[coreboot] New patch to review for coreboot: 51c61cd libpayload: libcbfs: Fix legacy CBFS API, typos

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Tue Feb 19 18:00:46 CET 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2455

-gerrit

commit 51c61cdd4f9a7d5d3a01d42a986564b2ccff6df8
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Tue Feb 19 17:59:21 2013 +0100

    libpayload: libcbfs: Fix legacy CBFS API, typos
    
    get_cbfs_header expects CBFS_HEADER_INVALID_ADDRESS (0xffffffff)
    instead of NULL when something is wrong.
    
    Also, fix typo.
    
    Change-Id: Ibe56c9eab3b9fdfc6d0b14bc848ca75f3a4fc2f1
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 payloads/libpayload/libcbfs/cbfs_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/payloads/libpayload/libcbfs/cbfs_core.c b/payloads/libpayload/libcbfs/cbfs_core.c
index 4fecd40..9bae188 100644
--- a/payloads/libpayload/libcbfs/cbfs_core.c
+++ b/payloads/libpayload/libcbfs/cbfs_core.c
@@ -62,8 +62,8 @@ const struct cbfs_header *cbfs_get_header(struct cbfs_media *media)
 	if (media == CBFS_DEFAULT_MEDIA) {
 		media = &default_media;
 		if (init_default_cbfs_media(media) != 0) {
-			ERROR("Failed to initializee default media.\n");
-			return NULL;
+			ERROR("Failed to initialize default media.\n");
+			return CBFS_HEADER_INVALID_ADDRESS;
 		}
 	}
 
@@ -103,7 +103,7 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name)
 	if (media == CBFS_DEFAULT_MEDIA) {
 		media = &default_media;
 		if (init_default_cbfs_media(media) != 0) {
-			ERROR("Failed to initializee default media.\n");
+			ERROR("Failed to initialize default media.\n");
 			return NULL;
 		}
 	}



More information about the coreboot mailing list