[coreboot] New patch to review for coreboot: 76abf16 AMD Fam15tn: dimmSpd.c: Set `iobase` to `SMBUS0_BASE_ADDRESS` instead of `0xB00`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Wed Feb 20 11:23:23 CET 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2459


commit 76abf1642cae937cf7c109c0fbcac341716b449e
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Tue Feb 19 14:46:31 2013 +0100

    AMD Fam15tn: dimmSpd.c: Set `iobase` to `SMBUS0_BASE_ADDRESS` instead of `0xB00`
    For AMD Inagua, the following two commits
        commit 01f7ab93359ae0fee5784d35effbcbe0b596df18
        Author: Kerry Sheh <shekairui at gmail.com>
        Date:   Thu Jan 19 13:18:36 2012 +0800
            Inagua: Synchronize AMD/inagua mainboard.
            Reviewed-on: http://review.coreboot.org/542
        commit d91c9b7e3cb9fdaeb9399a21907996130f3120bb
        Author: efdesign98 <efdesign98 at gmail.com>
        Date:   Thu Sep 15 10:59:55 2011 -0600
            AMD Inagua platform updates
            Reviewed-on: http://review.coreboot.org/136
    replaced the constant `iobase` is set to by the define `SMBUS0_BASE_ADDRESS` from `OEM.h`.
    Do the same for AMD Fam15tn used by AMD Parmer and Thatcher.
    Change-Id: I70dbf5b398e8abae1c20dc401f547abfe5b37a69
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/northbridge/amd/agesa/family15tn/dimmSpd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/northbridge/amd/agesa/family15tn/dimmSpd.c b/src/northbridge/amd/agesa/family15tn/dimmSpd.c
index 8b62a39..622564b 100644
--- a/src/northbridge/amd/agesa/family15tn/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family15tn/dimmSpd.c
@@ -26,6 +26,7 @@
 #include "amdlib.h"
 #include "dimmSpd.h"
 #include "chip.h"
+#include "OEM.h" /* SMBUS0_BASE_ADDRESS */
 #define DIMENSION(array)(sizeof (array)/ sizeof (array [0]))
@@ -154,7 +155,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 		[info->SocketId] [info->MemChannelId] [info->DimmId];
 	if (spdAddress == 0) return AGESA_ERROR;
-	ioBase = 0xB00;
 	setupFch (ioBase);
 	return readspd (ioBase, spdAddress, (void *) info->Buffer, 128);

More information about the coreboot mailing list