[coreboot] New patch to review for coreboot: acaf9f2 Persimmon: platform_cfg.h: Declare codec arrays as `static const`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Thu Feb 21 17:21:28 CET 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2474


commit acaf9f24c4280cb8c4f40aaa187b20746fd129bd
Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
Date:   Wed Feb 20 21:24:20 2013 +0100

    Persimmon: platform_cfg.h: Declare codec arrays as `static const`
    From ISO C99 standard: »The placement of a storage-class specifier
    other than at the beginning of the declaration specifiers in a
    declaration is an obsolescent feature.«
    Found at <http://www.approxion.com/?p=41>.
    Change-Id: Iee7878affb2a5d157a94763083689d75e8218b2f
    Signed-off-by: Jens Rottmann <JRottmann at LiPPERTembedded.de>
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/mainboard/amd/persimmon/platform_cfg.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/amd/persimmon/platform_cfg.h b/src/mainboard/amd/persimmon/platform_cfg.h
index 7051e7d..81593ca 100644
--- a/src/mainboard/amd/persimmon/platform_cfg.h
+++ b/src/mainboard/amd/persimmon/platform_cfg.h
@@ -227,7 +227,7 @@
 #define GEC_CONFIG			0
-const static CODECENTRY persimmon_codec_alc269[] =
+static const CODECENTRY persimmon_codec_alc269[] =
 	/* NID, PinConfig */
 	{0x12, 0x411111F0},
@@ -244,7 +244,7 @@ const static CODECENTRY persimmon_codec_alc269[] =
 	{0xff, 0xffffffff} /* end of table */
-const static CODECTBLLIST persimmon_codec_tablelist[] =
+static const CODECTBLLIST persimmon_codec_tablelist[] =
 	{0x010ec0269, (CODECENTRY*)&persimmon_codec_alc269[0]},

More information about the coreboot mailing list