[coreboot] [RFC] mainboard.c: Unify name of device/board enable function

Paul Menzel paulepanter at users.sourceforge.net
Sat Feb 23 22:09:06 CET 2013


Am Freitag, den 22.02.2013, 02:17 +0100 schrieb Peter Stuge:
> Paul Menzel wrote:
> >         struct chip_operations mainboard_ops = {
> >         	.enable_dev = inagua_enable,
> >         };
> > 
> > Naming this function is not uniform between the boards in the tree.
> 
> Depending on how mainboard_ops is used in all the boards maybe we
> want to simply remove it completely.
> 
> 
> > If there are no objections to unification, what should the name for the
> > function be?
> 
> Function names should try to be descriptive. "enable_dev" is not very
> descriptive. I like "mainboard_enable" because it makes output such
> as
> 
> printk("%s: foo", __func__);
> 
> useful.
> 
> 
> > Please comment on this, so a patch can be submitted.
> 
> I'd +2 a commit which renames all to mainboard_enable.

http://review.coreboot.org/2493

> It would be very nice to also add a test for this to the Jenkins
> build.

Indeed.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20130223/a24e5eda/attachment.sig>


More information about the coreboot mailing list