[coreboot] Patch set updated for coreboot: 32fd570 Persimmon: Fix warning, enable warnings as errors

Martin Roth (martin.roth@se-eng.com) gerrit at coreboot.org
Sun Feb 24 20:04:43 CET 2013

Martin Roth (martin.roth at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2494


commit 32fd57005cecfe6dc0eab58d2236603eb9409a6e
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Sat Feb 23 15:32:11 2013 -0700

    Persimmon: Fix warning, enable warnings as errors
     - Fix redefinition warning for SB_GPIO_REG50 introduced in commit
         fa8702cf - http://review.coreboot.org/#/c/2446/
         Persimmon: adapt PCIe reset code copied from Inagua to actually
                     match Persimmon
         The warning being fixed is:
            SB800.h:1491, GNU Compiler 4 (gcc), Priority: Normal
            "SB_GPIO_REG50" redefined [enabled by default]
     - Enable warnings as errors so no more warnings will be accidentally
    Change-Id: Ib443b2bd2067f0b7d5f93f79170899a0f8f61060
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
 src/mainboard/amd/persimmon/BiosCallOuts.h | 2 --
 src/mainboard/amd/persimmon/Kconfig        | 4 ----
 2 files changed, 6 deletions(-)

diff --git a/src/mainboard/amd/persimmon/BiosCallOuts.h b/src/mainboard/amd/persimmon/BiosCallOuts.h
index 25e5656..c4f4f70 100644
--- a/src/mainboard/amd/persimmon/BiosCallOuts.h
+++ b/src/mainboard/amd/persimmon/BiosCallOuts.h
@@ -70,6 +70,4 @@ AGESA_STATUS BiosHookBeforeExitSelfRefresh (UINT32 Func, UINT32 Data, VOID *Conf
 /* PCIE slot reset control */
 AGESA_STATUS BiosGnbPcieSlotReset (UINT32 Func, UINT32 Data, VOID *ConfigPtr);
-#define SB_GPIO_REG50	50
 #endif //_BIOS_CALLOUT_H_
diff --git a/src/mainboard/amd/persimmon/Kconfig b/src/mainboard/amd/persimmon/Kconfig
index 55d6b0c..f3f9aa9 100644
--- a/src/mainboard/amd/persimmon/Kconfig
+++ b/src/mainboard/amd/persimmon/Kconfig
@@ -121,8 +121,4 @@ config DRIVERS_PS2_KEYBOARD
 	default n
-	bool
-	default n

More information about the coreboot mailing list