[coreboot] Patch merged into coreboot/master: 528640d mainboard.c: Name enable_dev function uniformly `mainboard_enable`

gerrit at coreboot.org gerrit at coreboot.org
Mon Feb 25 18:47:01 CET 2013

the following patch was just integrated into master:
commit 528640d141193b4aaeb6b8956d4fbc7381df9eb3
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat Feb 23 21:31:23 2013 +0100

    mainboard.c: Name enable_dev function uniformly `mainboard_enable`
    To reduce the differences between these file name the enabling
    device function in the directory `src/mainboard` uniformly
    `mainboard_enable` [1].
    Thanks to the awesome help of gnomon and BlastHardcheese in the
    IRC channel #sed on <irc.freenode.net>. gnomon came up with the
    following command to do the actual work.
        $ cd src/mainboard
        $ for f in */*/mainboard.c ; \
        > do src="$(awk '/\.enable_dev = /{v=$NF; sub(/,$/,"",v); print v}' "$f")" ; \
        > [[ -z $src ]] && continue ; \
        > printf '%s\n' "g/${src}/s/${src}\([,(]\)/mainboard_enable\1/p" w | ed -s "$f" ; \
        > done
    `src/mainboard/digitallogic/msm586seg/mainboard.c` and
    `src/mainboard/technologic/ts5300/mainboard.c` had to be adapted
    manually as no comma was used separating the struct members.
    And with the following statement, gnomon is even more likable!
        My pleasure entirely.  Good luck with coreboot; I'm a big fan of the project.
    [1] http://www.coreboot.org/pipermail/coreboot/2013-February/074548.html
    Change-Id: Ife9cd0c2d9cc1ed14afc6d40063450553f06a6c6
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2493
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Sun Feb 24 14:31:15 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Mon Feb 25 18:47:00 2013, giving +2
See http://review.coreboot.org/2493 for details.


More information about the coreboot mailing list