[coreboot] Patch merged into coreboot/master: 5f20b35 QEMU x86: northbridge.c: Name enabling device function to `northbridge_enable`
gerrit at coreboot.org
gerrit at coreboot.org
Mon Feb 25 18:49:15 CET 2013
the following patch was just integrated into master:
commit 5f20b3522212f58b5e6858ff7028fb5a8e0879f5
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Sun Feb 24 14:27:03 2013 +0100
QEMU x86: northbridge.c: Name enabling device function to `northbridge_enable`
Similar to the discussion on the coreboot list [1]
Am Freitag, den 22.02.2013, 02:17 +0100 schrieb Peter Stuge:
[…]
> Function names should try to be descriptive. "enable_dev" is not very
> descriptive. I like "mainboard_enable" because it makes output such
> as
>
> printk("%s: foo", __func__);
>
> useful.
rename the function for the northbridge to `northbridge_enable`.
[1] http://www.coreboot.org/pipermail/coreboot/2013-February/074549.html
Change-Id: I262311ec511e394550330214621b8c37780c1d4e
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/2496
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martin.roth at se-eng.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
Build-Tested: build bot (Jenkins) at Sun Feb 24 14:40:22 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Mon Feb 25 18:49:15 2013, giving +2
See http://review.coreboot.org/2496 for details.
-gerrit
More information about the coreboot
mailing list