[coreboot] New patch to review for coreboot: 5b7b02b gitconfig: Give up commiting if the commit message is empty.

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Tue Feb 26 07:44:53 CET 2013

Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2523


commit 5b7b02b81c02e952af11fe958a5529df5529fd10
Author: Zheng Bao <fishbaozi at gmail.com>
Date:   Tue Feb 26 14:40:35 2013 +0800

    gitconfig: Give up commiting if the commit message is empty.
    With or without this change, git itself gives up commiting and
    prints the same error message.
    This just makes the commit-msg take more responsible. It also
    helps us how to give up commiting.
    Change-Id: I8b6e9eb258dde43776a4d55b4d198b2cc42535f0
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
 util/gitconfig/commit-msg | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/util/gitconfig/commit-msg b/util/gitconfig/commit-msg
index 82f0581..1a4e865 100755
--- a/util/gitconfig/commit-msg
+++ b/util/gitconfig/commit-msg
@@ -33,7 +33,8 @@ add_ChangeId() {
 	' "$MSG" | git stripspace`
 	if test -z "$clean_message"
-		return
+		echo "Aborting commit due to empty commit message."
+		exit 1
 	# Does Change-Id: already exist? if so, exit (no change).

More information about the coreboot mailing list