[coreboot] New patch to review for coreboot: dddb777 AMD Fam14 boards: reduce unnecessary differences, 2nd attempt
Jens Rottmann (JRottmann@LiPPERTembedded.de)
gerrit at coreboot.org
Tue Feb 26 16:21:30 CET 2013
Jens Rottmann (JRottmann at LiPPERTembedded.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2529
-gerrit
commit dddb77790818a66bd761e56ec6329587cd1756c8
Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
Date: Tue Feb 26 15:56:11 2013 +0100
AMD Fam14 boards: reduce unnecessary differences, 2nd attempt
This patch reduces unnecessary differences between AMD Inagua, Persimmon,
Union Station, South Station and Asrock E350M1. It's only cosmetical, but
makes them a little bit easier to compare.
This is the remainder of the original http://review.coreboot.org/2464,
parts of which somehow got lost in a flurry of refactoring and splitting
patches.
Change-Id: I034228be9edaaa4122506763d7bb4158f8e0ec53
Signed-off-by: Jens Rottmann <JRottmann at LiPPERTembedded.de>
---
src/mainboard/amd/inagua/mainboard.c | 8 ++++----
src/mainboard/amd/persimmon/mainboard.c | 6 +++---
src/mainboard/amd/persimmon/platform_cfg.h | 4 ++--
src/mainboard/amd/south_station/mainboard.c | 6 +++---
src/mainboard/amd/union_station/mainboard.c | 6 +++---
src/mainboard/asrock/e350m1/mainboard.c | 6 +++---
6 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/mainboard/amd/inagua/mainboard.c b/src/mainboard/amd/inagua/mainboard.c
index 2e2edc3..83ac9e8 100644
--- a/src/mainboard/amd/inagua/mainboard.c
+++ b/src/mainboard/amd/inagua/mainboard.c
@@ -70,9 +70,9 @@ void set_pcie_dereset(void)
}
-/*************************************************
- * enable the dedicated function in INAGUA board.
- *************************************************/
+/**********************************************
+ * Enable the dedicated functions of the board.
+ **********************************************/
static void mainboard_enable(device_t dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
@@ -82,5 +82,5 @@ static void mainboard_enable(device_t dev)
}
struct chip_operations mainboard_ops = {
- .enable_dev = mainboard_enable,
+ .enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/amd/persimmon/mainboard.c b/src/mainboard/amd/persimmon/mainboard.c
index 2f7cfd1..2d4916c 100644
--- a/src/mainboard/amd/persimmon/mainboard.c
+++ b/src/mainboard/amd/persimmon/mainboard.c
@@ -50,9 +50,9 @@ void set_pcie_dereset(void)
}
-/*************************************************
-* enable the dedicated function in persimmon board.
-*************************************************/
+/**********************************************
+ * Enable the dedicated functions of the board.
+ **********************************************/
static void mainboard_enable(device_t dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
diff --git a/src/mainboard/amd/persimmon/platform_cfg.h b/src/mainboard/amd/persimmon/platform_cfg.h
index 6590e4e..80e27ac 100644
--- a/src/mainboard/amd/persimmon/platform_cfg.h
+++ b/src/mainboard/amd/persimmon/platform_cfg.h
@@ -244,7 +244,7 @@ static const CODECENTRY persimmon_codec_alc269[] =
{0xff, 0xffffffff} /* end of table */
};
-static const CODECTBLLIST persimmon_codec_tablelist[] =
+static const CODECTBLLIST codec_tablelist[] =
{
{0x010ec0269, (CODECENTRY*)&persimmon_codec_alc269[0]},
{0x0FFFFFFFFUL, (CODECENTRY*)0x0FFFFFFFFUL}
@@ -254,7 +254,7 @@ static const CODECTBLLIST persimmon_codec_tablelist[] =
* @def AZALIA_OEM_VERB_TABLE
* Mainboard specific cocec verb table list
*/
-#define AZALIA_OEM_VERB_TABLE (&persimmon_codec_tablelist[0])
+#define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
/* set up an ACPI prefered power management profile */
/* from acpi.h
diff --git a/src/mainboard/amd/south_station/mainboard.c b/src/mainboard/amd/south_station/mainboard.c
index 4d3c804..0b0f208 100644
--- a/src/mainboard/amd/south_station/mainboard.c
+++ b/src/mainboard/amd/south_station/mainboard.c
@@ -73,9 +73,9 @@ static void southstation_led_init(void)
}
-/*************************************************
-* enable the dedicated function in southstation board.
-*************************************************/
+/**********************************************
+ * Enable the dedicated functions of the board.
+ **********************************************/
static void mainboard_enable(device_t dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
diff --git a/src/mainboard/amd/union_station/mainboard.c b/src/mainboard/amd/union_station/mainboard.c
index 57dfe44..c12e785 100644
--- a/src/mainboard/amd/union_station/mainboard.c
+++ b/src/mainboard/amd/union_station/mainboard.c
@@ -46,9 +46,9 @@ void set_pcie_dereset(void)
}
-/*************************************************
-* enable the dedicated function in unionstation board.
-*************************************************/
+/**********************************************
+ * Enable the dedicated functions of the board.
+ **********************************************/
static void mainboard_enable(device_t dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
diff --git a/src/mainboard/asrock/e350m1/mainboard.c b/src/mainboard/asrock/e350m1/mainboard.c
index 2bedff5..b92a149 100644
--- a/src/mainboard/asrock/e350m1/mainboard.c
+++ b/src/mainboard/asrock/e350m1/mainboard.c
@@ -45,9 +45,9 @@ void set_pcie_dereset(void)
}
-/*************************************************
-* enable the dedicated function in e350m1 board.
-*************************************************/
+/**********************************************
+ * Enable the dedicated functions of the board.
+ **********************************************/
static void mainboard_enable(device_t dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
More information about the coreboot
mailing list