[coreboot] New patch to review for coreboot: e2c0dc2 ASRock E350M1: Remove non-existing PCI devices 12.1 and 13.1

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Wed Feb 27 11:51:16 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2536

-gerrit

commit e2c0dc2f561c0655a454f50ac19d4b28dedfa8fd
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Wed Feb 27 11:17:59 2013 +0100

    ASRock E350M1: Remove non-existing PCI devices 12.1 and 13.1
    
    Looking at the coreboot log
    
        […]
        PCI: 00:12.0 [1002/4397] enabled
        sb800_enable() PCI: Static device PCI: 00:12.1 not found, disabling it.
        sb800_enable() PCI: 00:12.2 [1002/4396] ops
        PCI: 00:12.2 [1002/4396] enabled
        sb800_enable() PCI: 00:13.0 [1002/4397] ops
        PCI: 00:13.0 [1002/4397] enabled
        sb800_enable() PCI: Static device PCI: 00:13.1 not found, disabling it.
        sb800_enable() PCI: 00:13.2 [1002/4396] ops
        PCI: 00:13.2 [1002/4396] enabled
        […]
    
    and the `lspci -tnvv` output running the proprietary vendor BIOS
    attached to the Wiki page of the ASRock E350M1 [1][2]
    
            -[0000:00]-+-00.0  1022:1510
                       +-01.0  1002:9802
                       +-01.1  1002:1314
                       +-04.0-[01]--
                       +-11.0  1002:4391
                       +-12.0  1002:4397
                       +-12.2  1002:4396
                       +-13.0  1002:4397
                       +-13.2  1002:4396
            […]
    
    both PCI devices do not exist, so remove them from `devicetree.cb`.
    
    Commit 48918f7 [3]
    
        Persimmon, Inagua: PCI devs 12.1, 13.1 (USB) don't exist, but 14.6 (GEC) does
    
    did the same for AMD Inagua and AMD Persimmon.
    
    [1] http://www.coreboot.org/ASRock_E350M1
    [2] http://www.coreboot.org/File:ASRock_E350M1_info_dump.tar.bz2
    [3] http://review.coreboot.org/2463
    
    Change-Id: Ief6de1bda093d1f29d5925985e5c3839cdded537
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/asrock/e350m1/devicetree.cb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mainboard/asrock/e350m1/devicetree.cb b/src/mainboard/asrock/e350m1/devicetree.cb
index bc2beb1..0bb7f41 100644
--- a/src/mainboard/asrock/e350m1/devicetree.cb
+++ b/src/mainboard/asrock/e350m1/devicetree.cb
@@ -40,10 +40,8 @@ chip northbridge/amd/agesa/family14/root_complex
                                 chip southbridge/amd/cimx/sb800 # it is under NB/SB Link, but on the same pri bus
                                         device pci 11.0 on end # SATA
                                         device pci 12.0 on end # USB
-                                        device pci 12.1 on end # USB
                                         device pci 12.2 on end # USB
                                         device pci 13.0 on end # USB
-                                        device pci 13.1 on end # USB
                                         device pci 13.2 on end # USB
                                         device pci 14.0 on # SM
                                                 chip drivers/generic/generic #dimm 0-0-0



More information about the coreboot mailing list