[coreboot] Patch set updated for coreboot: 17b47dc update CFLAGS for armv7

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Fri Jan 4 00:31:30 CET 2013


Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2075

-gerrit

commit 17b47dca27f6e7b9c1b63623b42f1a60eb41742c
Author: David Hendricks <dhendrix at chromium.org>
Date:   Thu Dec 27 13:30:55 2012 -0800

    update CFLAGS for armv7
    
    This updates $CFLAGS used for armv7. Most of them were just added
    to be consistent with what u-boot does. The important ones here
    are -march=armv7-a and -mthumb (to allow 16-bit Thumb instructions).
    
    I removed the hard float support because it got errors and
    coreboot should never use floats anyway. We're still having trouble
    with enums but I want to see how far it gets with this patch.
    
    Also, put the flags in a form that makes diffs easier to read. It's
    almost impossible otherwise.
    
    Finally, move some flags to the architecture Makefile, and
    rely on the fact that some are set for all architectures.
    
    Depends-On: I6f730d017391f9ec4401cdfd34931c869df10a9e
    Change-Id: Ia8a1ae22959933e06f7b996d1832cea40819f1ff
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
---
 src/arch/armv7/Makefile.inc | 10 ++++++++++
 util/xcompile/xcompile      | 11 +++--------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/src/arch/armv7/Makefile.inc b/src/arch/armv7/Makefile.inc
index 1a1271f..41145d9 100644
--- a/src/arch/armv7/Makefile.inc
+++ b/src/arch/armv7/Makefile.inc
@@ -138,6 +138,16 @@ endif
 ################################################################################
 # done
 
+CFLAGS += \
+	-fno-common\
+	-ffixed-r8\
+	-mabi=aapcs-linux\
+	-march=armv7-a\
+	-marm\
+	-mno-unaligned-access\
+	-mthumb\
+	-mthumb-interwork
+
 # For various headers imported from Linux
 CFLAGS += -D__KERNEL__
 CFLAGS += -D__LINUX_ARM_ARCH__=7
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 4239176..ea975ec 100644
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -106,14 +106,9 @@ detect_special_flags() {
 		CFLAGS="$CFLAGS -Wl,--build-id=none"
 
 	case "$architecture" in
-		arm )
-			# testcc "$CC" "$CFLAGS -mcpu=cortex-a9" &&
-			#	CFLAGS="$CFLAGS -mcpu=cortex-a9"
-			testcc "$CC" "\
-$CFLAGS -ffixed-r8 -msoft-float -marm -mabi=aapcs-linux \
--mno-thumb-interwork -march=armv7 -mno-thumb-interwork" && CFLAGS="\
-$CFLAGS -ffixed-r8 -msoft-float -marm -mabi=aapcs-linux \
--mno-thumb-interwork -march=armv7 -mno-thumb-interwork"
+	armv7 )
+		ARMFLAGS=""
+		testcc "$CC" "$CFLAGS $ARMFLAGS"&&CFLAGS="$CFLAGS $ARMFLAGS"
 			;;
 	esac
 }



More information about the coreboot mailing list