[coreboot] Patch set updated for coreboot: 8fa685b cbfstool: index is replaced by strchr.

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Tue Jan 8 03:10:31 CET 2013

Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2112


commit 8fa685b1b18b12c6c672488a76f42dfda1604917
Author: zbao <fishbaozi at gmail.com>
Date:   Tue Jan 8 10:10:16 2013 +0800

    cbfstool: index is replaced by strchr.
    From index(3):
    CONFORMING TO 4.3BSD; marked as LEGACY in POSIX.1-2001. POSIX.1-2008
    removes the specifications of index() and rindex(), recommending
    strchr(3) and strrchr(3) instead.
    Change-Id: I3899b9ca9196dbbf2d147a38dacd7e742a3873fe
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: zbao <fishbaozi at gmail.com>
 util/cbfstool/cbfstool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index 6b52062..4202801 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -563,7 +563,7 @@ int main(int argc, char **argv)
 			/* filter out illegal long options */
-			if (index(commands[i].optstring, c) == NULL) {
+			if (strchr(commands[i].optstring, c) == NULL) {
 				/* TODO maybe print actual long option instead */
 				printf("%s: invalid option -- '%c'\n",
 					argv[0], c);

More information about the coreboot mailing list