[coreboot] Patch set updated for coreboot: 0de577a armv7: update board_init_f function signature

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Thu Jan 10 20:05:10 CET 2013

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2122


commit 0de577af9306dfa0bcda6dd45e96130dd2f23e0e
Author: David Hendricks <dhendrix at chromium.org>
Date:   Wed Jan 9 16:14:00 2013 -0800

    armv7: update board_init_f function signature
    We don't pass arguments when we jump out of assembly code.
    Change-Id: Iccf3a6f713e260b08f9ff47e8b542b9e96369166
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
 src/arch/armv7/include/common.h           | 3 +--
 src/cpu/samsung/exynos5-common/spl_boot.c | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/arch/armv7/include/common.h b/src/arch/armv7/include/common.h
index e21cfb0..2d4d020 100644
--- a/src/arch/armv7/include/common.h
+++ b/src/arch/armv7/include/common.h
@@ -164,8 +164,7 @@ void	init_cmd_timeout(void);
 void	reset_cmd_timeout(void);
 /* arch/$(ARCH)/lib/board.c */
-void	board_init_f  (ulong);
-//void	board_init_f  (ulong) __attribute__ ((noreturn));
+void	board_init_f  (void);
 void	board_init_r  (gd_t *, ulong) __attribute__ ((noreturn));
 int	checkboard    (void);
 int	checkflash    (void);
diff --git a/src/cpu/samsung/exynos5-common/spl_boot.c b/src/cpu/samsung/exynos5-common/spl_boot.c
index a734d5c..ecff871 100644
--- a/src/cpu/samsung/exynos5-common/spl_boot.c
+++ b/src/cpu/samsung/exynos5-common/spl_boot.c
@@ -308,7 +308,7 @@ static int __def_board_wakeup_permitted(void)
 int board_wakeup_permitted(void)
 	__attribute__((weak, alias("__def_board_wakeup_permitted")));
-void board_init_f(unsigned long bootflag)
+void board_init_f(void)
 	 * The gd struct is only needed for serial initialization. Since this

More information about the coreboot mailing list