[coreboot] Patch merged into coreboot/master: 6fe0cab Extend CBFS to support arbitrary ROM source media.

gerrit at coreboot.org gerrit at coreboot.org
Wed Jan 30 17:58:34 CET 2013

the following patch was just integrated into master:
commit 6fe0cab205e131525efbfce4f59da344b1e76598
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Tue Jan 22 18:57:56 2013 +0800

    Extend CBFS to support arbitrary ROM source media.
    	Isolate CBFS underlying I/O to board/arch-specific implementations as
    	"media stream", to allow loading and booting romstage on non-x86.
    	CBFS functions now all take a new "media source" parameter; use
    	CBFS_DEFAULT_MEDIA if you simply want to load from main firmware.
    	API Changes:
    		cbfs_find => cbfs_get_file.
    		cbfs_find_file => cbfs_get_file_content.
    		cbfs_get_file => cbfs_get_file_content with correct type.
    CBFS used to work only on memory-mapped ROM (all x86). For platforms like ARM,
    the ROM may come from USB, UART, or SPI -- any serial devices and not available
    for memory mapping.
    To support these devices (and allowing CBFS to read from multiple source
    at the same time), CBFS operations are now virtual-ized into "cbfs_media".  To
    simplify porting existing code, every media source must support both "reading
    into pre-allocated memory (read)" and "read and return an allocated buffer
    (map)". For devices without native memory-mapped ROM, "cbfs_simple_buffer*"
    provides simple memory mapping simulation.
    Every CBFS function now takes a cbfs_media* as parameter. CBFS_DEFAULT_MEDIA
    is defined for CBFS functions to automatically initialize a per-board default
    media (CBFS will internally calls init_default_cbfs_media).  Also revised CBFS
    function names relying on memory mapped backend (ex, "cbfs_find" => actually
    loads files). Now we only have two getters:
    	struct cbfs_file *entry = cbfs_get_file(media, name);
    	void *data = cbfs_get_file_content(CBFS_DEFAULT_MEDIA, name, type);
    Test results:
     - Verified to work on x86/qemu.
     - Compiles on ARM, and follow up commit will provide working SPI driver.
    Change-Id: Iac911ded25a6f2feffbf3101a81364625bb07746
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Reviewed-on: http://review.coreboot.org/2182
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Wed Jan 30 13:19:56 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Wed Jan 30 17:58:31 2013, giving +2
See http://review.coreboot.org/2182 for details.


More information about the coreboot mailing list