[coreboot] New patch to review for coreboot: c3f4e05 Google/snow: romstage that turns on memory and loads a ram stage with cbfs

ron minnich rminnich at gmail.com
Thu Jan 31 04:03:57 CET 2013


yeah, these are terrible names. Those pointers are going away soon anyway.

ron

On Wed, Jan 30, 2013 at 5:11 PM, Bernhard Urban <lewurm at gmail.com> wrote:
> I can't log into gerrit at the moment, so I reply here.
>
> On Thu, Jan 31, 2013 at 1:08 AM, Ronald G. Minnich <gerrit at coreboot.org> wrote:
>> +       /* wow, did it work? */
>> +       int i;
>> +       u32 *c = (void *)0x40000000;
>
> what is at 0x40000000? what is "c"?
> Please use a define or a more descriptive name for the pointer.
>
>
> Thanks,
> Bernhard
>
> --
> coreboot mailing list: coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot



More information about the coreboot mailing list