[coreboot] New patch to review for coreboot: 9689bab watchdog.h: Fix compile time error on disabling watchdog handling

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Mon Mar 11 18:35:47 CET 2013

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2627


commit 9689bab5f4381087bc82fa658df325edea1ae03f
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Mon Mar 11 18:32:50 2013 +0100

    watchdog.h: Fix compile time error on disabling watchdog handling
    There's a compile time error that we didn't catch since it's
    board defaults as used by the build bot won't expose it.
    Just make watchdog_off() a no-op statement so there aren't any
    stray semicolons in the preprocessor output.
    Change-Id: Ib5595e7e8aa91ca54bc8ca30a39b72875c961464
    Reported-by: 'lautriv' on irc.freenode.net/#coreboot
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
 src/include/watchdog.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/include/watchdog.h b/src/include/watchdog.h
index d626737..b94cd4d 100644
--- a/src/include/watchdog.h
+++ b/src/include/watchdog.h
@@ -4,7 +4,7 @@
 void watchdog_off(void);
-#define watchdog_off()
+#define watchdog_off() while(0) {}
 #endif /* WATCHDOG_H */

More information about the coreboot mailing list