[coreboot] New patch to review for coreboot: eee227a src/mainboard: Drop redundant `CHIP_NAME` again for new ports
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Wed Mar 13 15:49:42 CET 2013
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2708
-gerrit
commit eee227aea44de383aa979ce1d52dfccf4d859f82
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Wed Mar 13 13:29:44 2013 +0100
src/mainboard: Drop redundant `CHIP_NAME` again for new ports
Since commit »Drop redundant CHIP_NAME in mainboard.c« (a93c3fe7) [1]
`CHIP_NAME` is unneeded for mainboards as the name is composed
automatically in `src/devices/root_device.c` from the strings in
Kconfig.
Unfortunately the ports for Google Butterfly, Link and Parrot as
as well as IEI PM-LX2-800-R10 introduced CHIP_NAME again. So drop
it again too.
[1] http://review.coreboot.org/1635
Change-Id: Ice7577a2a5c6070e196f2647c440b7a8e140e27e
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
src/mainboard/google/butterfly/mainboard.c | 1 -
src/mainboard/google/link/mainboard.c | 1 -
src/mainboard/google/parrot/mainboard.c | 1 -
src/mainboard/iei/pm-lx2-800-r10/mainboard.c | 1 -
4 files changed, 4 deletions(-)
diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c
index 53b9631..beda107 100644
--- a/src/mainboard/google/butterfly/mainboard.c
+++ b/src/mainboard/google/butterfly/mainboard.c
@@ -502,6 +502,5 @@ static void mainboard_enable(device_t dev)
}
struct chip_operations mainboard_ops = {
- CHIP_NAME("Google Butterfly Chromebook")
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/google/link/mainboard.c b/src/mainboard/google/link/mainboard.c
index a7ddb4d..e40ce52 100644
--- a/src/mainboard/google/link/mainboard.c
+++ b/src/mainboard/google/link/mainboard.c
@@ -351,6 +351,5 @@ static void mainboard_enable(device_t dev)
}
struct chip_operations mainboard_ops = {
- CHIP_NAME("Google Link Chromebook")
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/google/parrot/mainboard.c b/src/mainboard/google/parrot/mainboard.c
index 7f5b01e..4c2618d 100644
--- a/src/mainboard/google/parrot/mainboard.c
+++ b/src/mainboard/google/parrot/mainboard.c
@@ -323,6 +323,5 @@ static void mainboard_enable(device_t dev)
}
struct chip_operations mainboard_ops = {
- CHIP_NAME("Google Parrot Chromebook")
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/iei/pm-lx2-800-r10/mainboard.c b/src/mainboard/iei/pm-lx2-800-r10/mainboard.c
index e7d1646..f7f82c8 100644
--- a/src/mainboard/iei/pm-lx2-800-r10/mainboard.c
+++ b/src/mainboard/iei/pm-lx2-800-r10/mainboard.c
@@ -47,6 +47,5 @@ static void mainboard_enable(struct device *dev)
}
struct chip_operations mainboard_ops = {
- CHIP_NAME("IEI PM-LX2-800-R10 Mainboard")
.enable_dev = mainboard_enable,
};
More information about the coreboot
mailing list