[coreboot] New patch to review for coreboot: fbd0ee8 libpayload: Put dump_td/dump_ed in ohci.c behind #ifdef USB_DEBUG

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu Mar 14 00:14:36 CET 2013

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2716


commit fbd0ee8a4ed861ed2c149203e512bc0edb2f97cd
Author: Gabe Black <gabeblack at google.com>
Date:   Wed Jan 16 03:18:45 2013 -0800

    libpayload: Put dump_td/dump_ed in ohci.c behind #ifdef USB_DEBUG
    This function is static and not used in that file. To avoid the compiler
    complaining about that fact, put the two functions and the call to dump_ed
    (currently #if 0) behind #ifdef USB_DEBUG
    Change-Id: Ic373313b5fff81f09800f286b32238350ab699c6
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
 payloads/libpayload/drivers/usb/ohci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c
index c670373..44eba31 100644
--- a/payloads/libpayload/drivers/usb/ohci.c
+++ b/payloads/libpayload/drivers/usb/ohci.c
@@ -46,6 +46,7 @@ static void ohci_destroy_intr_queue (endpoint_t *ep, void *queue);
 static u8* ohci_poll_intr_queue (void *queue);
 static void ohci_process_done_queue(ohci_t *ohci, int spew_debug);
+#ifdef USB_DEBUG
 static void
 dump_td (td_t *cur)
@@ -116,6 +117,7 @@ dump_ed (ed_t *cur)
 static void
 ohci_reset (hci_t *controller)
@@ -429,7 +431,7 @@ ohci_control (usbdev_t *dev, direction_t dir, int drlen, void *devreq, int dalen
 	usb_debug("ohci_control(): doing transfer with %x. first_td at %x\n",
 		head->config & ED_FUNC_MASK, virt_to_phys(first_td));
-#if 0
+#ifdef USB_DEBUG

More information about the coreboot mailing list