[coreboot] Patch merged into coreboot/master: 1cb414d libpayload: Turn the endian conversion macros into functions.

gerrit at coreboot.org gerrit at coreboot.org
Thu Mar 14 04:56:05 CET 2013


the following patch was just integrated into master:
commit 1cb414de638d6885ad3a8510594ea1df7d4d96a6
Author: Gabe Black <gabeblack at google.com>
Date:   Fri Mar 8 04:38:13 2013 -0800

    libpayload: Turn the endian conversion macros into functions.
    
    In their current macro form, any arguments that are expressions will be
    evaluated multiple times. That can cause problems if they have side effects,
    and might not even compile if the overall expression is ambiguous, for
    instance if you pass in foo++.
    
    Built with code that previously wouldn't compile because the macros
    expanded to ambiguous expressions.
    
    Change-Id: I378c04d7aff5b4ad40581930ce90e49ba7df1d3e
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: http://review.coreboot.org/2719
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Thu Mar 14 01:33:03 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Thu Mar 14 04:56:04 2013, giving +2
See http://review.coreboot.org/2719 for details.

-gerrit



More information about the coreboot mailing list