[coreboot] Patch set updated for coreboot: 583280c Persimmon DSDT: Remove INI method from AZHD device

Mike Loptien (mike.loptien@se-eng.com) gerrit at coreboot.org
Thu Mar 14 23:35:50 CET 2013

Mike Loptien (mike.loptien at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2726


commit 583280c34cdb2ef182c45e0124494e81921f2ad1
Author: Mike Loptien <mike.loptien at se-eng.com>
Date:   Thu Mar 14 16:07:09 2013 -0600

    Persimmon DSDT: Remove INI method from AZHD device
    I am removing the _INI method from the AZHD device because
    it does not seem to do anything and causes errors in the
    FWTS[1] (Firmware Test Suite) test 'method'. The INI
    method performs device specific initialization and is
    run when OSPM loads a description table.  It must only
    access OperationRegions that have been indicated as
    available by the _REG (Region) method.  We do not have a
    _REG method and during my testing, I added a REG method
    but it did not seem to make a difference in the PCI
    register space.  The bit fields defined as NSDI (Disable
    No Snoop), NSDO (Disable No Snoop Override), and NSEN
    (Enable No Snoop Request) do not ever get written from
    their default values.  And writing to these bit fields
    does not seem to be necessary.  Comparing to AMI bios,
    they setup these same bit fields in an OperatingRegion
    but never write to them.
    In an effort to clean up as many FWTS errors as possible,
    I propose removing this method altogether.  I have seen no
    change in operation (audio works with and without this
    method) and there does not seem to be any change in lspci
    or dmesg.
    FWTS information can be found here:
    [1]: https://wiki.ubuntu.com/Kernel/Reference/fwts
    Change-Id: If8d86f959822d528c44ab011a851659d486289b5
    Signed-off-by: Mike Loptien <mike.loptien at se-eng.com>
 src/mainboard/amd/persimmon/dsdt.asl | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/mainboard/amd/persimmon/dsdt.asl b/src/mainboard/amd/persimmon/dsdt.asl
index dff5917..acc85c6 100644
--- a/src/mainboard/amd/persimmon/dsdt.asl
+++ b/src/mainboard/amd/persimmon/dsdt.asl
@@ -1385,14 +1385,6 @@ DefinitionBlock (
 					offset (0x6C),
 					MMDT, 16,
-				Method(_INI) {
-					If(LEqual(OSTP,3)){   /* If we are running Linux */
-						Store(zero, NSEN)
-						Store(one, NSDO)
-						Store(one, NSDI)
-					}
-				}
 			} /* end AZHD */
 			Device(LIBR) {

More information about the coreboot mailing list