[coreboot] Patch merged into coreboot/master: 8d629c1 Persimmon DSDT: Remove INI method from AZHD device

gerrit at coreboot.org gerrit at coreboot.org
Fri Mar 15 17:07:02 CET 2013

the following patch was just integrated into master:
commit 8d629c14eb776ce6e243218bb554a335dc0f3672
Author: Mike Loptien <mike.loptien at se-eng.com>
Date:   Thu Mar 14 16:07:09 2013 -0600

    Persimmon DSDT: Remove INI method from AZHD device
    I am removing the _INI method from the AZHD device because
    it does not seem to do anything and causes errors in the
    FWTS[1] (Firmware Test Suite) test 'method'. The INI
    method performs device specific initialization and is
    run when OSPM loads a description table.  It must only
    access OperationRegions that have been indicated as
    available by the _REG (Region) method.  We do not have a
    _REG method and during my testing, I added a REG method
    but it did not seem to make a difference in the PCI
    register space.  The bit fields defined as NSDI (Disable
    No Snoop), NSDO (Disable No Snoop Override), and NSEN
    (Enable No Snoop Request) do not ever get written from
    their default values.  And writing to these bit fields
    does not seem to be necessary because I did not notice
    any change in audio functionality.
    In an effort to clean up as many FWTS errors as possible,
    I propose removing this method altogether.  I have seen no
    change in operation (audio works with and without this
    method) and there does not seem to be any change in lspci
    or dmesg.
    FWTS information can be found here:
    [1]: https://wiki.ubuntu.com/Kernel/Reference/fwts
    Change-Id: If8d86f959822d528c44ab011a851659d486289b5
    Signed-off-by: Mike Loptien <mike.loptien at se-eng.com>
    Reviewed-on: http://review.coreboot.org/2726
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Fri Mar 15 01:31:47 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Fri Mar 15 17:07:01 2013, giving +2
See http://review.coreboot.org/2726 for details.


More information about the coreboot mailing list