[coreboot] New patch to review for coreboot: a1ec073 Lippert Fam14 DSDT: Remove INI method from AZHD device

[Mike Loptien (mike.loptien@se-eng.com)]

Mike Loptien (mike.loptien at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2743

-gerrit

commit a1ec07344a580eeb24949f88b2e88ce087c8527b
Author: Mike Loptien <mike.loptien at se-eng.com>
Date:   Fri Mar 15 13:40:13 2013 -0600

    Lippert Fam14 DSDT: Remove INI method from AZHD device
    
    I am removing the _INI method from the AZHD device because
    it does not seem to do anything and causes errors in the
    FWTS[1] (Firmware Test Suite) test 'method'. The INI
    method performs device specific initialization and is
    run when OSPM loads a description table.  It must only
    access OperationRegions that have been indicated as
    available by the _REG (Region) method.  We do not have a
    _REG method and during my testing, I added a REG method
    but it did not seem to make a difference in the PCI
    register space.  The bit fields defined as NSDI (Disable
    No Snoop), NSDO (Disable No Snoop Override), and NSEN
    (Enable No Snoop Request) do not ever get written from
    their default values.  And writing to these bit fields
    does not seem to be necessary because I did not notice
    any change in audio functionality.
    
    In an effort to clean up as many FWTS errors as possible,
    I propose removing this method altogether.  I have seen no
    change in operation (audio works with and without this
    method) and there does not seem to be any change in lspci
    or dmesg.
    
    FWTS information can be found here:
    [1]: https://wiki.ubuntu.com/Kernel/Reference/fwts
    
    This is the same change as made to Persimmon in
    Change-ID If8d86f:
    http://review.coreboot.org/#/c/2726/
    
    Change-Id: Iff594d4a3493531561eb25d1cceeb97bcefde424
    Signed-off-by: Mike Loptien <mike.loptien at se-eng.com>
---
 src/mainboard/lippert/frontrunner-af/dsdt.asl | 8 --------
 src/mainboard/lippert/toucan-af/dsdt.asl      | 8 --------
 2 files changed, 16 deletions(-)

diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl
index d3b88f7..1e8c09e 100644
--- a/src/mainboard/lippert/frontrunner-af/dsdt.asl
+++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl
@@ -1373,14 +1373,6 @@ DefinitionBlock (
 					offset (0x6C),
 					MMDT, 16,
 				}
-
-				Method(_INI) {
-					If(LEqual(OSTP,3)){   /* If we are running Linux */
-						Store(zero, NSEN)
-						Store(one, NSDO)
-						Store(one, NSDI)
-					}
-				}
 			} /* end AZHD */
 
 			Device(LIBR) {
diff --git a/src/mainboard/lippert/toucan-af/dsdt.asl b/src/mainboard/lippert/toucan-af/dsdt.asl
index cde41b4..cdde01a 100644
--- a/src/mainboard/lippert/toucan-af/dsdt.asl
+++ b/src/mainboard/lippert/toucan-af/dsdt.asl
@@ -1373,14 +1373,6 @@ DefinitionBlock (
 					offset (0x6C),
 					MMDT, 16,
 				}
-
-				Method(_INI) {
-					If(LEqual(OSTP,3)){   /* If we are running Linux */
-						Store(zero, NSEN)
-						Store(one, NSDO)
-						Store(one, NSDI)
-					}
-				}
 			} /* end AZHD */
 
 			Device(LIBR) {