[coreboot] Patch merged into coreboot/master: 60d84ca ASROCK Fam14 DSDT: Remove INI method from AZHD device

gerrit at coreboot.org gerrit at coreboot.org
Sun Mar 17 19:55:31 CET 2013

the following patch was just integrated into master:
commit 60d84ca22b57ae5705c0659aa07a59a3407c094e
Author: Mike Loptien <mike.loptien at se-eng.com>
Date:   Fri Mar 15 13:36:25 2013 -0600

    ASROCK Fam14 DSDT: Remove INI method from AZHD device
    I am removing the _INI method from the AZHD device because
    it does not seem to do anything and causes errors in the
    FWTS[1] (Firmware Test Suite) test 'method'. The INI
    method performs device specific initialization and is
    run when OSPM loads a description table.  It must only
    access OperationRegions that have been indicated as
    available by the _REG (Region) method.  We do not have a
    _REG method and during my testing, I added a REG method
    but it did not seem to make a difference in the PCI
    register space.  The bit fields defined as NSDI (Disable
    No Snoop), NSDO (Disable No Snoop Override), and NSEN
    (Enable No Snoop Request) do not ever get written from
    their default values.  And writing to these bit fields
    does not seem to be necessary because I did not notice
    any change in audio functionality.
    In an effort to clean up as many FWTS errors as possible,
    I propose removing this method altogether.  I have seen no
    change in operation (audio works with and without this
    method) and there does not seem to be any change in lspci
    or dmesg.
    FWTS information can be found here:
    [1]: https://wiki.ubuntu.com/Kernel/Reference/fwts
    This is the same change as made to Persimmon in
    Change-ID If8d86f:
    Change-Id: Iae70c3d0af1cdaca31b206ad6daba4d38ee6b780
    Signed-off-by: Mike Loptien <mike.loptien at se-eng.com>
    Reviewed-on: http://review.coreboot.org/2742
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Fri Mar 15 22:31:15 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Sun Mar 17 19:55:28 2013, giving +2
See http://review.coreboot.org/2742 for details.


More information about the coreboot mailing list