[coreboot] Patch merged into coreboot/master: 8aa210b bd82x6x: don't use absolute symbols

gerrit at coreboot.org gerrit at coreboot.org
Sun Mar 17 22:50:05 CET 2013


the following patch was just integrated into master:
commit 8aa210bbf0343b1da1ab4e164c22da13c985a796
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Feb 8 16:14:07 2013 -0600

    bd82x6x: don't use absolute symbols
    
    objcopy -B provides symbols of the form _binary_<name>_(start|end|size).
    However, the _size variant is an absoult symbol.  If one wants to
    relocate the smi loading the _size symbol will be relocated which is
    wrong since it is suppose to be a fixed size. There is no way to
    distinguish symbols that shouldn't be relocated vs ones that can.
    Instead use the _start and _end variants to determine the size.
    
    Change-Id: I55192992cf36f62a9d8dd896e5fb3043a3eacbd3
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/2760
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Sat Mar 16 01:44:44 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Sun Mar 17 22:50:04 2013, giving +2
See http://review.coreboot.org/2760 for details.

-gerrit



More information about the coreboot mailing list