[coreboot] Patch merged into coreboot/master: e919837 cbfstool locate: Rename -a align switch to -P for page size

gerrit at coreboot.org gerrit at coreboot.org
Tue Mar 19 11:12:11 CET 2013

the following patch was just integrated into master:
commit e91983767c64f5541bae44d3b95fa2646bc1a311
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Tue Mar 19 12:17:12 2013 +0800

    cbfstool locate: Rename -a align switch to -P for page size
    cbfstool usage change:
       The "-a" parameter for "cbfstool locate" is switched to "-P/--page-size".
    The "locate" command was used to find a place to store ELF stage image in one
    memory page. Its argument "-a (alignment)" was actually specifying the page size
    instead of doing memory address alignment. This can be confusing when people are
    trying to put a blob in aligned location (ex, microcode needs to be aligned in
    0x10), and see this:
      cbfstool coreboot.rom locate -f test.bin -n test -a 0x40000
      # output: 0x44, which does not look like aligned to 0x40000.
    To prevent confusion, it's now switched to "-P/--page-size".
    Verified by building i386/axus/tc320 (with page limitation 0x40000):
     cbfstool coreboot.rom locate -f romstage_null.bin -n romstage -P 0x40000
     # output: 0x44
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Change-Id: I0893adde51ebf46da1c34913f9c35507ed8ff731
    Reviewed-on: http://review.coreboot.org/2730
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)

Build-Tested: build bot (Jenkins) at Tue Mar 19 11:10:49 2013, giving +1
Reviewed-By: Paul Menzel <paulepanter at users.sourceforge.net> at Tue Mar 19 10:13:12 2013, giving +2
See http://review.coreboot.org/2730 for details.


More information about the coreboot mailing list