[coreboot] New patch to review for coreboot: d3e6ce1 Remove __PRE_RAM__ guard around log2 prototype

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Tue Mar 19 19:58:20 CET 2013

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2832


commit d3e6ce1ffd918180713069e30b128abc289ceeae
Author: David Hendricks <dhendrix at chromium.org>
Date:   Tue Mar 19 11:55:44 2013 -0700

    Remove __PRE_RAM__ guard around log2 prototype
    The prototype for log2() should be visible everywhere except romcc,
    which is handled by an #ifndef __ROMCC__ just above this guard.
    Change-Id: I713569ed95bd5427db0e5dc3e3f0499bd1914297
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
 src/include/lib.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/include/lib.h b/src/include/lib.h
index 9d81085..31b8669 100644
--- a/src/include/lib.h
+++ b/src/include/lib.h
@@ -24,10 +24,8 @@
 #include <stdint.h>
 #ifndef __ROMCC__ /* romcc doesn't support prototypes. */
-#ifndef __PRE_RAM__ /* Conflicts with romcc_io.h */
-/* Defined in src/lib/clog2.c */
+/* Defined in src/lib/clog2.c (note: conflicts with romcc_io.h) */
 unsigned long log2(unsigned long x);
 /* Defined in src/lib/lzma.c */
 unsigned long ulzma(unsigned char *src, unsigned char *dst);

More information about the coreboot mailing list