[coreboot] Patch merged into coreboot/master: e4ea2ca cbfstool locate: Implement alignment switch --align/-a

gerrit at coreboot.org gerrit at coreboot.org
Wed Mar 20 05:47:33 CET 2013

the following patch was just integrated into master:
commit e4ea2ca18d4764f8c79560d373d548d52532566d
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Tue Mar 19 12:24:43 2013 +0800

    cbfstool locate: Implement alignment switch --align/-a
    cbfstool usage change:
     "-a" for "cbfstool locate" can specify base address alignment.
    To support putting a blob in aligned location (ex, microcode needs to be aligned
    in 0x10), alignment (-a) is implemented into "locate" command.
    Verified by manually testing a file (324 bytes) with alignment=0x10:
     cbfstool coreboot.rom locate -f test -n test -a 0x10
     # output: 0x71fdd0
     cbfstool coreboot.rom add -f test -n test -t raw -b 0x71fdd0
     cbfstool coreboot.rom print -v -v
     # output: test                           0x71fd80   raw          324
     # output:  cbfs_file=0x71fd80, offset=0x50, content_address=0x71fdd0+0x144
    Also verified to be compatible with old behavior by building i386/axus/tc320
    (with page limitation 0x40000):
     cbfstool coreboot.rom locate -f romstage_null.bin -n romstage -P 0x40000
     # output: 0x44
     cbfstool coreboot.rom locate -f x.bin -n romstage -P 0x40000 -a 0x30
     # output: 0x60
    Change-Id: I78b549fe6097ce5cb6162b09f064853827069637
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Reviewed-on: http://review.coreboot.org/2824
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)

Build-Tested: build bot (Jenkins) at Tue Mar 19 11:22:27 2013, giving +1
Reviewed-By: Paul Menzel <paulepanter at users.sourceforge.net> at Tue Mar 19 10:15:17 2013, giving +2
See http://review.coreboot.org/2824 for details.


More information about the coreboot mailing list