[coreboot] Adding checks for non-ASCII filenames (was: [Gerrit] gitconfig: Add sample checks shipped by git to pre-commit hook)

Peter Stuge peter at stuge.se
Thu May 30 12:10:25 CEST 2013


Paul Menzel wrote:
> as non-ASCII characters are not allowed in our source [1]

Where the hell did you get the idea that there is such a policy?

You are extrapolating discussion about four characters in two files
between two individuals to a tree-wide project-wide policy. That is
absolutely unreasonable!


> I assume they are also not allowed in file names.

Don't assume.. Especially not based on extrapolation like that.


> The sample pre-commit hook shipped by git has a check for non-ASCII
> file names, which can be disabled by a config option.

Either we have a policy or we do not. If we have a policy then why do
we care what the sample hook does?


> Are there any circumstances where non-ASCII characters might be needed?

I don't think so and quite likely they would break things, so I
would be in favor of a policy to only allow ASCII filenames.


> If not, Peter is right and the option can be removed from the
> script, which I would do then.

You shouldn't have pushed a commit in the first place without
strong consensus to back it up. Working together, communication,
all that.


//Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20130530/5872debf/attachment.sig>


More information about the coreboot mailing list