[coreboot] How to best add new boards derived from existing board?

Paul Menzel paulepanter at users.sourceforge.net
Sun Sep 29 23:16:51 CEST 2013


Dear coreboot folks,


it is great to see patches adding new boards to our repository. Lately
this was AMD Olive Hill [1], ASRock IMB-A180 [2] and just now the Micro
Passion Kratos-X1 [3].

The Olive Hill took a AMD Family 15 board as a template, the IMB-A180
was derived from the Olive Hill and, I believe, the Kratos-X1 is also
derived from one of these two. (Derived means, an existing board’s
directory was copied and then adapted.)

With the current approach it is difficult to see the actual changes to
the template board. Especially in Gerrit. Therefore these board support
patches are hard to review.

Do you know, how to avoid this problem? Currently, I came only up with
adding a “copy-commit” with just the Kconfig name changes and then the
actual changes in a separate commit on top of it. Jens Rottmann did the
same when adding the LiPPERT (now ADLINK) boards [4][5].


Thanks,

Paul


[1] http://review.coreboot.org/3784
[2] http://review.coreboot.org/3880
[3] http://review.coreboot.org/3951
[4] http://review.coreboot.org/2552
[5] http://review.coreboot.org/2553
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20130929/f8437abf/attachment.sig>


More information about the coreboot mailing list