[coreboot] New Defects reported by Coverity Scan for coreboot

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

3 new defect(s) introduced to coreboot found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1229574:  Unchecked return value  (CHECKED_RETURN)
/src/drivers/spi/spi_flash.c: 73 in spi_flash_read_common()

** CID 1256585:  Unchecked return value  (CHECKED_RETURN)
/src/cpu/amd/agesa/spi.c: 39 in spi_SaveS3info()

** CID 1256584:  Unchecked return value  (CHECKED_RETURN)
/src/ec/google/chromeec/ec_spi.c: 33 in crosec_spi_io()


________________________________________________________________________________________________________
*** CID 1229574:  Unchecked return value  (CHECKED_RETURN)
/src/drivers/spi/spi_flash.c: 73 in spi_flash_read_common()
67     		size_t cmd_len, void *data, size_t data_len)
68     {
69     	struct spi_slave *spi = flash->spi;
70     	int ret;
71     
72     	spi->rw = SPI_READ_FLAG;
>>>     CID 1229574:  Unchecked return value  (CHECKED_RETURN)
>>>     Calling "spi_claim_bus" without checking return value (as is done elsewhere 12 out of 15 times).
73     	spi_claim_bus(spi);
74     	ret = spi_flash_cmd_read(spi, cmd, cmd_len, data, data_len);
75     	spi_release_bus(spi);
76     
77     	return ret;
78     }

________________________________________________________________________________________________________
*** CID 1256585:  Unchecked return value  (CHECKED_RETURN)
/src/cpu/amd/agesa/spi.c: 39 in spi_SaveS3info()
33     		printk(BIOS_DEBUG, "Could not find SPI device\n");
34     		/* Dont make flow stop. */
35     		return;
36     	}
37     
38     	flash->spi->rw = SPI_WRITE_FLAG;
>>>     CID 1256585:  Unchecked return value  (CHECKED_RETURN)
>>>     Calling "spi_claim_bus" without checking return value (as is done elsewhere 12 out of 15 times).
39     	spi_claim_bus(flash->spi);
40     
41     	flash->erase(flash, pos, size);
42     	flash->write(flash, pos, sizeof(len), &len);
43     	flash->write(flash, pos + sizeof(len), len, buf);
44     

________________________________________________________________________________________________________
*** CID 1256584:  Unchecked return value  (CHECKED_RETURN)
/src/ec/google/chromeec/ec_spi.c: 33 in crosec_spi_io()
27     			 uint8_t *read_bytes, size_t read_size,
28     			 void *context)
29     {
30     	struct spi_slave *slave = (struct spi_slave *)context;
31     	int rv;
32     
>>>     CID 1256584:  Unchecked return value  (CHECKED_RETURN)
>>>     Calling "spi_claim_bus" without checking return value (as is done elsewhere 12 out of 15 times).
33     	spi_claim_bus(slave);
34     	rv = spi_xfer(slave, write_bytes, write_size, read_bytes,
35     		      read_size);
36     	spi_release_bus(slave);
37     
38     	if (rv != 0) {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan.coverity.com/projects/1016?tab=overview

To manage Coverity Scan email notifications for "coreboot at coreboot.org", click http://scan.coverity.com/subscriptions/edit?email=coreboot%40coreboot.org&token=8ddd1fe26945626880b796e94d465567 .