[coreboot] how to model the Quark architecture

[Stojsavljevic, Zoran]

>> -----Original Message-----
>> From: coreboot-bounces at coreboot.org [mailto:coreboot-bounces at coreboot.org] On Behalf Of Patrick Georgi
>> 
>> And not just in a formal way (which indent could solve), but I'd rather not see things like
>> (BIT31 | BIT30 | BIT29 | .. all the way down to .. | BIT 1 | BIT 0) in our tree.
>> 
>> While looking terribly enterprisey, it's just terrible.
>> Intel code, at least as far as it is public and not part of the Linux kernel, manages to collect all the horrible code standards in a single place.

// Bit defs 
#define BIT0                     0x0001 
#define BIT1                     0x0002 
#define BIT2                     0x0004 
#define BIT3                     0x0008 
#define BIT4                     0x0010 
#define BIT5                     0x0020 
#define BIT6                     0x0040 
#define BIT7                     0x0080 
#define BIT8                     0x0100 
#define BIT9                     0x0200 
#define BIT10                    0x0400 
#define BIT11                    0x0800 
#define BIT12                    0x1000 
#define BIT13                    0x2000 
#define BIT14                    0x4000 
#define BIT15                    0x8000 
#define BIT16                0x00010000 
#define BIT17                0x00020000 
#define BIT18                0x00040000 
#define BIT19                0x00080000 
#define BIT20                0x00100000 
#define BIT21                0x00200000 
#define BIT22                0x00400000 
#define BIT23                0x00800000 
#define BIT24                0x01000000 
#define BIT25                0x02000000 
#define BIT26                0x04000000 
#define BIT27                0x08000000 
#define BIT28                0x10000000 
#define BIT29                0x20000000 
#define BIT30                0x40000000 
#define BIT31                0x80000000

Laugh of The Day! ;-)

Zoran

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052